railsdevs.com icon indicating copy to clipboard operation
railsdevs.com copied to clipboard
verified publisher icon joemasilotti

Link to "impersonate" from `/admin/users` and remove `/admin/impersonate`

Open joemasilotti opened this issue 3 years ago • 3 comments

A PR addressing this issue should:

  1. Link to "Impersonate" from each user in /admin/users
  2. Remove the views and links for /admin/impersonate

joemasilotti avatar Aug 19 '22 01:08 joemasilotti

Hi @joemasilotti Can I work on this issue?

vsmay98 avatar Aug 21 '22 13:08 vsmay98

Sure thing, all yours @vsmay98!

joemasilotti avatar Aug 21 '22 19:08 joemasilotti

Hello there! Is there any progress in this issue @vsmay98 ? I already have something working on my local fork to submit.

KarlHeitmann avatar Sep 01 '22 03:09 KarlHeitmann

Hi @KarlHeitmann Please go ahead and raise a PR. I will unassign myself from this issue.

vsmay98 avatar Sep 05 '22 07:09 vsmay98

Ok, thanks. Here is the work in progress: https://github.com/joemasilotti/railsdevs.com/pull/627

I need to do the other two items from the checklist: My code contains tests covering the code I modified and I added significant changes and product updates to the changelog, you can review it and send any other feedback.

KarlHeitmann avatar Sep 05 '22 14:09 KarlHeitmann

Closed via #627.

joemasilotti avatar Sep 14 '22 02:09 joemasilotti