Joel Warrington

Results 17 comments of Joel Warrington

Hi @rmosolgo, wanted to give some insight into how we're currently using (or abusing) `load_application_object_failed`. We're currently transitioning from integer IDs to global IDs, and doing so in a gradual...

Wanted to add on to my previous comment, after finding out about the `authorized?` issue, we have used a work-around to get around this if anyone is in a similar...

Also - one issue I noticed is that the `withPageAuthRequired` wasn't redirecting a user to login when they had an expired session/JWT, but would fail on the `getAccessToken` method. One...

hey @adamjmcgrath, thanks for reaching out, I'll look to setup an example which reproduces my issue. But if you want to try and reproduce: - refresh token grant enabled on...

@adamjmcgrath what's the difference between session and access token? So it's possible for someone to have a logged in session, but an expired access token?

I see, thank you for sharing that explanation. It would be nice for these to be documented in some way, although I don't know what the best way is. As...

Looking at source code - I can see this method implemented here: https://github.com/octokit/octokit.rb/blob/676d31ff52f624ba2661f826c19fdd079aa89b8f/lib/octokit/client/repositories.rb#L212 But the documentation is not up to date: http://octokit.github.io/octokit.rb/method_list.html 🤔

I think that the 1:1 mappings are inconsistent, as I've seen something like `.message` or `.messages` which is not a 1:1 mapping. In my opinion, when building a Ruby client,...

@Spone do you think I could work on this next? Once #160 is released this would be relatively easy to implement in configuration.