vscode-private-extension-manager icon indicating copy to clipboard operation
vscode-private-extension-manager copied to clipboard

Support private extension packs and private extension dependencies

Open lachaib opened this issue 4 years ago • 7 comments

Hello,

While trying to bundle several private extensions along as extensionPack or extensionDependencies, I discovered that it's not possible to install private extensions through them. (Btw, while looking at the code I found a typo)

From what I read in installExtensionByPackage, what would need to be done is to extract from manifest for fields extensionPack and extensionDependencies, and for each element in the lists, try to see if they can be found in any registry, in which case they should be also be installed by installExtensionById. If not found in registry, call workbench.extensions.installExtension command as done currently.

This would also be a good opportunity for private registries to be a cache for large extensions.

Thanks

lachaib avatar Nov 20 '20 16:11 lachaib

@joelspadin-garmin This would be a beneficial addition to the manager. In my company, we have multiple private extensions and want to create a private extension pack that bundles private and public extensions. As @lachaib is suggesting, the code changes would be to read through the extensionPack and extensionDependencies before executing workbench.extensions.installExtension, and installing any private extensions available in the registry.

kumar121193 avatar Aug 18 '22 10:08 kumar121193

@joelspadin-garmin Please let me know if this enhancement can be added. I am happy to contribute if needed.

kumar121193 avatar Aug 18 '22 10:08 kumar121193

Sorry for the late response. Yes, this does sound like something that could be useful. I don't have time to implement it though.

joelspadin-garmin avatar Sep 29 '22 14:09 joelspadin-garmin

I can make the contribution but I've changed company since and won't be able to test it. Anyone who'd be eager to test?

lachaib avatar Sep 29 '22 15:09 lachaib

@lachaib @joelspadin-garmin Any update on this?

kumar121193 avatar Dec 14 '22 07:12 kumar121193

I can make the contribution but I've changed company since and won't be able to test it. Anyone who'd be eager to test?

I've tested it.It's useful。

josiezhan avatar Feb 23 '23 10:02 josiezhan

I can make the contribution but I've changed company since and won't be able to test it. Anyone who'd be eager to test?

I've tested it.It's useful。

Thanks @KINGZJS Can you mention your test in the pull request as well? Now we'll need @joelspadin-garmin to merge and release it.

lachaib avatar Feb 23 '23 11:02 lachaib