plusastab icon indicating copy to clipboard operation
plusastab copied to clipboard

Fix documentation

Open leandroribeiro opened this issue 9 years ago • 3 comments

Hi Joe,

I found two problems in the documentation.

First, there is one reference to "PlusOnTab" but the correct property is "PlusAsTab".

Second, when using JQuery selector to include and exclude, need put exclude selectors first.

Thats all.

leandroribeiro avatar Jun 11 '15 13:06 leandroribeiro

@leandroribeiro: hmm. What is the problem you see when you put the include before the exclude? Disabling elements should work as expected no matter which order you execute $(selector).plusAsTab(false); with or without false.

From joelpurra/plusastab#disabling-plussing:

Disabling plussing takes precedence over enabling plussing.

Can you please write a test case to show me the bug? I'd prefer a test in the current test framework, but using jsbin or jsfiddle would work as well. See test/basic.js.

Thanks for finding the typo! I'd like to fix it, but since it's in the same pull request as what I am asking above, I cannot merge it until that has been resolved. I would gladly accept a separate pull request fixing only the typo though =)

joelpurra avatar Jun 11 '15 14:06 joelpurra

Hi Joel,

When I was testing in IE11 it doesn't works when I put exclude selectors after include selector, but I will make tests for this too.

And after I will create other pull request about the typo.

leandroribeiro avatar Jun 12 '15 01:06 leandroribeiro

@leandroribeiro: I don't have access to IE11, so that would be great! The typo fix would be great as well =)

Thank you for your efforts!

joelpurra avatar Jun 12 '15 06:06 joelpurra