Jacques Eloff
Jacques Eloff
+1 Multiple SDK PRs impacted before RC2 branding/snapshots.
I tried running this PR in a dogfood environment and see a completely different error: ``` C:\git\sdk>dotnet tool install System.ValueTuple Unhandled exception: System.IO.DirectoryNotFoundException: Could not find a part of the...
Thanks, that makes sense and I understand better now where @marcpopMSFT wanted me to pick this up
Think I figured out the rest. If the package already exists, we assume it is a tool package and then we can fail. Updating the PR with an additional check...
> @joeloff, can you make sure to re-test: > > > Does this search work if the package is unlisted and the version is explicitly specified? > > before merging?...
Looks like unlisted still works from my dogfood 
@baronfel here's a screenshot of the new error experience 
> Ok you're going to hate me but if we know the package isn't a tool we shouldn't show the rest of the exception (everything from line 2 onwards). I...
> I seem to remember you made the same comment to me, and after looking around, I found that I could just change `throw new ToolPackageException` into `throw new GracefulException`,...
And here's the screenshot for switching to `GracefulException` 