nothis icon indicating copy to clipboard operation
nothis copied to clipboard

"fixthis" is an ambiguous function name

Open jbccollins opened this issue 7 years ago • 2 comments

The README on "fixthis":

Prevents the rebinding of this

The name of that function in no way indicates what it actually does. How about "lockthis" or "freezethis" or something similar?

jbccollins avatar Aug 09 '18 15:08 jbccollins

Naming is my kryptonite. I will spend 30 minutes on a character creating screen trying to figure out that I should call the avatar.

These names are good suggestions.

joelnet avatar Aug 09 '18 20:08 joelnet

The nothisAll is not intuitive to me. Consider using fixThisClass since it's meant to be used in the constructor of a class.

styfle avatar Aug 14 '18 20:08 styfle