dynamic_form icon indicating copy to clipboard operation
dynamic_form copied to clipboard

update gem for rails 6.1 + ruby 3.0.2

Open robmathews opened this issue 3 years ago • 6 comments

Mostly ruby 2.7+, I guess, since it was just keyword parameters.

robmathews avatar Aug 17 '21 17:08 robmathews

It looks like it does what it is supposed to 🎉

I was unable to (quickly) get the tests running locally (likely due to rails 3 and ancient rake not playing nice with a modern system), so could not validate it that way.

I've integrated this into my own fork to test it in practice against a large real codebase, and deprecation warnings disappeared in the test suite, without introducing new errors. Consider this anecdotal evidence for working on rails 6.1 + ruby 2.7. 👍

Narnach avatar Aug 31 '21 10:08 Narnach

thanks for this 👍

janxious avatar Jan 07 '22 20:01 janxious

Any chance this could get integrated for a RubyGems release?

calebwoods avatar Apr 30 '22 01:04 calebwoods

I tried to get the tests to run on github actions, but test-unit is ancient, stubbing is done through mocha and I'm getting several weird errors.

https://github.com/payrollhero/dynamic_form/runs/6333790595 https://test-unit.github.io https://mocha.jamesmead.org/

anyone know what provides convert_to_model ?

mathieujobin avatar May 07 '22 10:05 mathieujobin

anyone know what provides convert_to_model ?

part of ActionView, it used to be in a different place so maybe the included module needs to change or something https://apidock.com/rails/ActionView/ModelNaming/convert_to_model

janxious avatar May 07 '22 18:05 janxious

Note that I have tried switching my app to use this branch, and I am getting several tests failures. I have yet to investigate what they are.

mathieujobin avatar May 08 '22 00:05 mathieujobin