ruby_luhn icon indicating copy to clipboard operation
ruby_luhn copied to clipboard

CLI

Open indikaimk opened this issue 13 years ago • 6 comments

Added a CLI.

indikaimk avatar Jun 04 '12 09:06 indikaimk

Nice feature!

Unless I'm missing something I think you accidentally added some temporary files from your editor (ending with ~)

Could you remove them and squash?

joeljunstrom avatar Jun 04 '12 09:06 joeljunstrom

Oh!... I am still new to Ruby. Can you tell me where this method get_input_number is.

indikaimk avatar Jun 16 '12 10:06 indikaimk

I will remove the temporary file and upload ASAP

indikaimk avatar Jun 16 '12 10:06 indikaimk

Regarding the get_input_number, in the validate method you use the get_input_number method, but in the calculate method you seem to reimplement it?

joeljunstrom avatar Jun 16 '12 14:06 joeljunstrom

Oops..I will correct it and upload. That has been a silly mistake...

indikaimk avatar Jun 16 '12 16:06 indikaimk

No worries mate, just make a new commit and squash your branch and then force push it.

http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html

Thanks!

joeljunstrom avatar Jun 18 '12 09:06 joeljunstrom