karma-parallel icon indicating copy to clipboard operation
karma-parallel copied to clipboard

Published 20 hours ago • verified publisher icon joeljeske

Fix disconnect race condition

Open nvladimirovi opened this issue 4 years ago • 4 comments

Issue: The previous implementation was not taking under consideration that two browsers can disconnect at the same time.

Fix: Collect all shard indexes in array of disconnected browsers.

Testing Done:

  • Verify the test sets will be reconnected to the correct shard index and there will be no 1 of 1 test sets, when 2 browsers disconnect at the same time.
  • Please check if the PR fulfills these requirements
  • [x] The commit message follows our guidelines
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Bug fix.

  • What is the current behavior? (You can also link to an open issue here) If two browsers disconnect at the same time the second will create new shard index and will cause 1 of 1 test set.

  • What is the new behavior (if this is a feature change)? Each disconnected browser shard index will be stored in disconnected browsers array and when the new browsers try to reconnect they will get their old shard indexes, ensuring no 1 of 1 test sets.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?) No breaking changes.

  • Other information:

nvladimirovi avatar Mar 19 '20 13:03 nvladimirovi

@joeljeske Can this review be looked at? It fixes https://github.com/joeljeske/karma-parallel/issues/42

juanmendes avatar Jun 17 '20 15:06 juanmendes

Hi @joeljeske

I was also facing this issue in my project, where i have around 10K + test cases and few of them are always skipped (randomly any test case not particular) when the browser is disconnected. I tried consuming this code in my local and it is work fine.

Please can you check and merge this PR.

Thanks

sukhbirsinghsaini avatar Jul 20 '20 10:07 sukhbirsinghsaini

Hi @juanmendes @sukhbirsinghsaini , did you guys found a workaround to this issue ? We're facing the same one..

FrapperColin avatar Nov 18 '20 16:11 FrapperColin

Hi @juanmendes @sukhbirsinghsaini , did you guys found a workaround to this issue ? We're facing the same one..

We applied the patch from this pull request

juanmendes avatar Nov 18 '20 18:11 juanmendes