jsonschema2pojo icon indicating copy to clipboard operation
jsonschema2pojo copied to clipboard

Support custom Generated annotation that uses runtime retention policy required by JaCoCo

Open marioja opened this issue 1 year ago • 9 comments

The javax.annotation.Generated or javax.annotation.processing.Generated annotation all use SOURCE retention policy which is not compatible with JaCoCo code coverage which works at the byte code level. We need to have the ability to use a custom generated annotation instead of or in addition to the javax annotation.

marioja avatar Mar 05 '23 15:03 marioja

I am working on a pull request.

marioja avatar Mar 05 '23 15:03 marioja

I think we can use an existing pull request for this.

What annotation does JaCoCo expect?

joelittlejohn avatar Mar 05 '23 16:03 joelittlejohn

JaCoCo requires a runtime retention policy annotation. What existing pull request are you talking about?

marioja avatar Mar 06 '23 00:03 marioja

Have a look at PR #1499 and let me know if you need anything.

marioja avatar Mar 06 '23 14:03 marioja

Hi @joelittlejohn, is there any issue with my PR #1499? You might have been waiting until I was done and I think I am and just need your review.

marioja avatar Mar 15 '23 14:03 marioja

@joelittlejohn Could this PR #1499 be merged or do you require something more from me? I would like to use it in our builds and would appreciate if this could be accepted. Thanks

marioja avatar Apr 03 '23 18:04 marioja

@joelittlejohn gentle ping. Do you think PR #1499 could be merged? @billkoch is this something you would use? I have been using the artifact from my repo for a number of months with no issues and I would like to switch to @joelittlejohn's artifact.

marioja avatar Sep 20 '23 12:09 marioja

@marioja this is definitely something I would use! Without this feature, I've been adding the generated classes to a JaCoCo ignore list.

Thank you for taking the time to report the issue and open a PR for it! ❤️

billkoch avatar Oct 02 '23 13:10 billkoch

@billkoch Well I pinged joelittlejohn, so all we can do is wait for him to respond on the PR.

marioja avatar Oct 02 '23 15:10 marioja