jsonschema2pojo icon indicating copy to clipboard operation
jsonschema2pojo copied to clipboard

Custom Generation Config not getting respected

Open CrystallDEV opened this issue 3 years ago • 2 comments

When creating a custom annotator with a custom generation config (Class that implements the GenerationConfig interface), the config does not get respected and gets overriden with the DefaultGenerationConfig / the values present in the Mojo class.

This restricts us to only customize the parameters using the maven plugin configuration section. I checked out the source code and noticed that the GenerationConfig interface gets implemented in the Mojo class and that the values in the mojo class are used in the generation call.

There should be a check for a custom config and / or merge the values handed into the plugin through the configuration section and a custom config.

CrystallDEV avatar Aug 05 '21 12:08 CrystallDEV

I am running into this as well. Any update?

octgsoftware avatar Aug 14 '22 22:08 octgsoftware

I started implementing this but never finished it and also didn't create a PR for it. I was mainly running into problems syncing the pom values and the custom values, since this wasn't initially implemented in one location and instead got implemented twice

CrystallDEV avatar Aug 15 '22 09:08 CrystallDEV