video-to-ascii icon indicating copy to clipboard operation
video-to-ascii copied to clipboard

Fix windows compatibility

Open joelibaceta opened this issue 3 years ago • 4 comments

Some incompatibilities do not allow this tool to run correctly on windows. I will list some of them:

  • [ ] The stty size command is used to obtain the terminal's size, which generates the unknown command error in windows.

joelibaceta avatar Dec 26 '20 04:12 joelibaceta

maybe it's better to add an option to specifiy max width and max height?

ZSaberLv0 avatar Jan 07 '21 04:01 ZSaberLv0

Actually, using os.get_terminal_size() can return a tuple of the console window's columns and lines, which can be useful for windows porting.

>>> import os
>>> os.get_terminal_size()
os.terminal_size(columns=160, lines=40)

creativegamer03 avatar Mar 30 '21 04:03 creativegamer03

@creativegamer03 do you think you can do a PR with that?

joelibaceta avatar Apr 01 '21 15:04 joelibaceta

@creativegamer03 do you think you can do a PR with that?

idk... I'll try tho..

creativegamer03 avatar Apr 05 '21 11:04 creativegamer03