bowhead icon indicating copy to clipboard operation
bowhead copied to clipboard

withoutOverlapping will actually run command every 24 hours

Open jankulma opened this issue 6 years ago • 1 comments

Hello,

In https://github.com/joeldg/bowhead/blob/master/app/Console/Kernel.php#L47 you use withoutOverlapping which should prevent executing a command if it is already running. But if you see this method, you'll notice that there is an argument with default value 1440 which stands for 24h. So basically the command will be run again every 24 hours, despite if it is already running or not.

Some more details: https://github.com/laravel/framework/issues/18202

I'm not sure if this is actually an issue for you. I build my own app loosely inspired by yours, and I encountered this, so I wanted to share it.

Thanks, Jan

PS I posted this twice, please delete https://github.com/joeldg/bowhead/issues/115

jankulma avatar Jul 17 '18 14:07 jankulma

thanks, will look into it.. been swamped lately

joeldg avatar Jul 24 '18 20:07 joeldg