ProtonVPN-Gtk icon indicating copy to clipboard operation
ProtonVPN-Gtk copied to clipboard

Better UI For Server Selection

Open joelbduncan opened this issue 6 years ago • 8 comments

Server selection UI could do with an update.

Limiting the max height and adding search functionally would clean up the visuals and make server selection quicker

joelbduncan avatar Mar 31 '18 22:03 joelbduncan

Yeah that would be solid, a checkbox/radio button filter ability could compliment it nicely for trying to find secure_core, p2p, Tor, or normal servers.

MitchellRandom avatar Mar 31 '18 23:03 MitchellRandom

I like that idea! I think I want to get this Threading issue in the bag before pushing with this though.

joelbduncan avatar Apr 01 '18 12:04 joelbduncan

Or make 2 dropdowns, one by country and the other one by servers in that country.

Rafficer avatar Apr 02 '18 15:04 Rafficer

I like this! I think I'd like to implement that with radio buttons as suggested by @MitchellHaleUK.

I might see if I can get a mock-up tonight and maybe functionality if I can.

Good shout! Thanks for the feedback

joelbduncan avatar Apr 02 '18 15:04 joelbduncan

Work started on toggle switches very rough implementation that does work but is some ugly code! https://github.com/Slethen/ProtonVPN-Gtk/tree/radio-btn-filter

When this is done I'll see about two Dropdowns as suggested by @Rafficer

joelbduncan avatar Apr 03 '18 15:04 joelbduncan

I can see where you are coming from the server list building, however, the Secure Core servers will have to be approached in a different way as '-' is present in all US servers and FREE servers. Perhaps it might prove beneficial to add an additional column to indicate server types.

MitchellRandom avatar Apr 03 '18 16:04 MitchellRandom

That's what I was thinking, I'm also trying to clean it up so the function to write the list isn't repeated in the program.

At the moment I have this, it doesn't work unfortunately python doesn't agree with what I want to do.

funtion

joelbduncan avatar Apr 03 '18 21:04 joelbduncan

Toggle switches now in master.

Standard, Secure Core, Tor & P2P are selectable.

I didn't add one for free as free users can't see premium server's and I can't imagine paid users will be searching for free servers often.

joelbduncan avatar Apr 05 '18 00:04 joelbduncan