vienna
vienna copied to clipboard
joehoyle
Add Aztec editor
See #4.
Early days, don't merge yet!
Currently fatal errors with any content with media in it, since we don't have a media delegate set. Seems like that's not in the Obj-C headers, so might need to switch to Swift for this...
Probably want to sync up with https://github.com/joehoyle/vienna/pull/35 when possible as that's on RN 0.44. Also, I am maintaining https://github.com/joehoyle/vienna/blob/master/upgrade-react-native.md as a log of how to set the project up a new, as basically when it comes to doing a RN upgrade it's basically a nuke and re-do the xcode project. Not ideal, but I think having this log is also good if we ever were to break the xcodeproject too.
Looks like we need to switch to Swift, per https://github.com/wordpress-mobile/AztecEditor-iOS/pull/475
Fine by me, but we'll need a small bridge for the RN macros.
Editor's now in and firing events and such. Currently, typing too fast will cause problems as the UIView updates before React propagates the change back to the component. Typing slowly does work though, so people just need to be more thoughtful about what they're typing. #feature
Will think through best way to solve this, suspect I'll end up with a solution similar to FK.