robert-bruce icon indicating copy to clipboard operation
robert-bruce copied to clipboard

classes are checked after running error-hook

Open danlarkin opened this issue 9 years ago • 1 comments

In the catch block [1] inside robert.bruce/retry, error-hook is called on t and THEN try-again? is called, but this means that the error hook can't know the type of Throwable it's getting - even if :classes lists only one.

I propose the evaluation order be reversed.

danlarkin avatar Mar 05 '15 15:03 danlarkin

I have thought about this a lot, and I can totally see that there's a need for a hook that has access to the thing that you're asking for, but it's different than what the error-hook is for.

I'm going to noodle on this a bit more and see if I can get something in that gives you what you're asking for, but leaves the error-hook as it is.

Thanks for the message!

joegallo avatar May 08 '15 20:05 joegallo