Joe Flack
Joe Flack
- [x] @joeflack4 `medgen` repo: Move MeSH xrefs into a secondary robot template which will not currently be used. - [x] @joeflack4 `mondo` repo: Pull down into this PR the...
- [x] @matentzn or @twhetzel review I've completed [the tasks](https://github.com/monarch-initiative/mondo/pull/7467#issuecomment-2094008926) for splitting out MeSH xrefs as requested. Now ready for re-review / merge. Results: [Google Sheet - general (no MeSH)](https://docs.google.com/spreadsheets/d/1OD7WUR-nJ9lUqRv01TTghmf3aGvQRbWV5ZhVhthzB6U/edit#gid=1627855620)...
@matentzn This is [ready to be merged](https://github.com/monarch-initiative/mondo/pull/7467#issuecomment-2102243758), but I think you still need to mark resolved your [requested changes](https://github.com/monarch-initiative/mondo/pull/7467#pullrequestreview-2037933418). The requested change (split MeSH out) has been completed: 1. here...
FYI I added this to the [tech meeting agenda tomorrow](https://docs.google.com/document/d/1pKyAZsT1ZlZxxgkNBRucvQPwsxzDF0nhGC2VaiPLj_U/edit). --- @cmungall @matentzn @twhetzel If OAK has means to validate illegal proxy matches, shouldn't `sssom-py` also? I just checked and...
@matentzn Yes: https://github.com/monarch-initiative/medgen/blob/e70aa96a23d61161428afade432ff834c9dcafa9/makefile#L113-L114
I think this sounds good. If you can clarify, @kanems, why should we delete CNs again? It sounds like Nico is saying to delete them because they're redundant with UIDs....
@matentzn FYI just wanting to let you know where I'm at.
@hrshdhgd Yeah, I figured that would be the case for `relation-graph`. That's a little too involved to install that with the pipeline we have. I think I'll wait until that...
That sounds hopeful! Thanks Chris.
@hrshdhgd @cmungall I was trying to get `semsql` to work today in order to troubleshoot some issues I'm having with trying to use `SqlImplementation` in OAK. I had a lot...