react-native-cookies icon indicating copy to clipboard operation
react-native-cookies copied to clipboard
verified publisher icon joeferraro

Suggested improvements

Open tuckerconnelly opened this issue 9 years ago • 5 comments

  • Use promises instead of callbacks
  • Simplify api to match js-cookie--just need get, set, and remove; don't wanna deal with cookie strings

tuckerconnelly avatar Oct 17 '16 12:10 tuckerconnelly

lets move to promises.

kaminskypavel avatar Oct 31 '16 14:10 kaminskypavel

Happy to accept a PR

joeferraro avatar Oct 31 '16 15:10 joeferraro

Using this in my project now, and would prefer promise-based APIs. Can I take a stab at this? @joeferraro @kaminskypavel

ycai2 avatar Mar 23 '17 23:03 ycai2

Absolutely On Thu, Mar 23, 2017 at 7:40 PM Yisheng Cai [email protected] wrote:

Using this in my project now, and would prefer promise-based APIs. Can I take a stab at this? @joeferraro https://github.com/joeferraro @kaminskypavel https://github.com/kaminskypavel

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/joeferraro/react-native-cookies/issues/44#issuecomment-288892956, or mute the thread https://github.com/notifications/unsubscribe-auth/AADTjd6oR_x8QoOLmfOMhkOc3QglSA0hks5rowLugaJpZM4KYlFk .

joeferraro avatar Mar 24 '17 00:03 joeferraro

@ycai2 promises are in place, cheers

joeferraro avatar Aug 08 '17 16:08 joeferraro