laravel-translation icon indicating copy to clipboard operation
laravel-translation copied to clipboard

Use `/lang` instead of `/resources/lang`

Open efectn opened this issue 3 years ago • 2 comments

Describe the bug If laravel-translation package shares languages to resources/lang, Laravel uses resources/lang as default langPath (you can check it by using app()->langPath()). And then, it causes problem if we don't put any language files in resources/lang.

Expected behavior Package should use lang as default language path.

Screenshots 2022-09-02_20-57

Desktop (please complete the following information):

  • OS: Arch Linux
  • Browser Chrome
  • Version 104

If you're OK, i can create a PR for this :rocket:

efectn avatar Sep 02 '22 17:09 efectn

True. Vote +1

ProfConsulting avatar Sep 16 '22 08:09 ProfConsulting

True. Vote +1

HayderThamer92 avatar Sep 17 '22 07:09 HayderThamer92

A PR would be great 🙌

joedixon avatar Sep 20 '22 20:09 joedixon

True. Vote +1

ruwad-co avatar Oct 29 '22 22:10 ruwad-co

Just as an info, since I had similiar issue. You need just to delete the directory /resources/lang (copy existing files if needed in /lang). Laravel and the plugin use automatically the /lang folder...

riomigal avatar Dec 02 '22 08:12 riomigal