coinaddr icon indicating copy to clipboard operation
coinaddr copied to clipboard

Add support for Bech32 format of BTC and LTC

Open j4nk0 opened this issue 2 years ago • 2 comments

Add support for Litecoin testnet Q... addresses Add new currency litecoin-segwit for bech32 address format on mainnet ant testnet. Add new currency bitcoin-segwit for bech32 address format on mainnet ant testnet Add validator logic for validating bech32 addresses

j4nk0 avatar May 26 '22 11:05 j4nk0

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.01%.

Quality metrics Before After Change
Complexity 1.93 ⭐ 1.93 ⭐ 0.00
Method Length 39.70 ⭐ 40.64 ⭐ 0.94 👎
Working memory 5.37 ⭐ 5.34 ⭐ -0.03 👍
Quality 81.73% 81.72% -0.01% 👎
Other metrics Before After Change
Lines 223 242 19
Changed files Quality Before Quality After Quality Change
coinaddr/currency.py 71.96% 🙂 70.09% 🙂 -1.87% 👎
coinaddr/validation.py 84.06% ⭐ 84.84% ⭐ 0.78% 👍
tests/test_validation.py 93.61% ⭐ 93.48% ⭐ -0.13% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

sourcery-ai[bot] avatar May 26 '22 11:05 sourcery-ai[bot]

Thanks for opening this and being patient, I need a minute to review the code and preferably setup some CI/CD for the repo for QC.

joeblackwaslike avatar Oct 17 '22 15:10 joeblackwaslike