minio-exporter icon indicating copy to clipboard operation
minio-exporter copied to clipboard

add seq label to storage_type

Open stefanmonkey opened this issue 7 years ago • 3 comments

add seq label into storage_type in func collectStorageInfo to fix issue #2

after add , metrics output like

# HELP minio_storage_storage_type Minio backend storage type used
# TYPE minio_storage_storage_type gauge
minio_storage_storage_type{seq="0",type="Erasure"} 2
minio_storage_storage_type{seq="1",type="Erasure"} 2
minio_storage_storage_type{seq="2",type="Erasure"} 2
minio_storage_storage_type{seq="3",type="Erasure"} 2

stefanmonkey avatar Nov 29 '17 03:11 stefanmonkey

Hi, after reading your PR I realised that the storageInfo are the same for all the servers. I sligthly modified the code. Could you please try to build from the branch 'server-data-info-fix' and tell me if you're still experiencing the problem? I started a 4 servers (16 exports) as you suggested to do and it works for me.

If it works for you too i'll merge it and build a new docker image. After that, can you please create another PR with the grafana dashboards?

joe-pll avatar Dec 21 '17 00:12 joe-pll

@joe-pll I have create pr #5.

stefanmonkey avatar Dec 21 '17 07:12 stefanmonkey

Great job

rustup avatar Feb 28 '18 11:02 rustup