pyvoro icon indicating copy to clipboard operation
pyvoro copied to clipboard

Feature/python3 -- resurrecting @wackywendell's python 3 support branch.

Open joe-jordan opened this issue 9 years ago • 3 comments

A little while ago @wackywendell kindly made a couple of small changes for python three support and added some unit tests.

Here, I am finally adding these to the main repo. Will keep this as a PR while I check over the unit tests and code coverage.

joe-jordan avatar Nov 11 '15 22:11 joe-jordan

coverage gaps:

  • numpy array inputs
  • periodic boundary conditions
  • with/without radii
  • trigger voro++ error "number of cells not equal to the number of input particles" (I think this is triggered when a particle is on one of the walls, or outside the bounds?)

joe-jordan avatar Nov 11 '15 23:11 joe-jordan

Also, noticed that the Cython function has mutable arg defaults. It doesn't mutate them, but this should be fixed anyway.

joe-jordan avatar Nov 11 '15 23:11 joe-jordan

Hi! Glad you were interested in doing this. Just thought I'd give you a heads up: I also wrote tess (docs here), which is another interface for voro++ with a more object-oriented interface. But its nice to also see pyvoro getting python 3 support!

wackywendell avatar Nov 12 '15 00:11 wackywendell