react-native-linkedin-login icon indicating copy to clipboard operation
react-native-linkedin-login copied to clipboard

Published 20 hours ago • verified publisher icon jodybrewster

Android build failed

Open dmitrika opened this issue 6 years ago • 4 comments

Hi!

Trying to setup android and can't build it. Failing with following error:

***/node_modules/react-native-linkedin-login/android/src/main/java/net/jodybrewster/linkedinlogin/RNLinkedinLoginPackage.java:29: error: method does not override or implement a method from a supertype
    @Override
    ^
1 error
:react-native-linkedin-login:compileReleaseJavaWithJavac FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':react-native-linkedin-login:compileReleaseJavaWithJavac'.

Any ideas what can be wrong?

"react-native-linkedin-login": "^1.44.1",
"react-native": "0.51.0",

dmitrika avatar Mar 21 '18 07:03 dmitrika

Fixed by removing @Override, is it ok and we should commit it? I'm not really into Java world.

dmitrika avatar Mar 22 '18 13:03 dmitrika

@dmitrika I'll take a look soon

jodybrewster avatar Mar 28 '18 11:03 jodybrewster

The root cause of this build error is the following a React Native breaking change https://github.com/facebook/react-native/issues/15232 and the solution seems to be to remove the @override line.

dejavughost avatar Apr 29 '18 19:04 dejavughost

Any update? I'm asking because it's ridiculous removing this line each time when a new developer install project on his pc.

VentroArt avatar Aug 29 '19 08:08 VentroArt