Josh de Leeuw

Results 160 comments of Josh de Leeuw

Hi @thtTNT, I think this is a good idea. It might make sense to consolidate the `initialize-camera` and `initialize-microphone` plugins, and just give parameters for whether developers want video, audio,...

I think adding a new `initialize-recording` plugin might be the cleanest way to signal the change. Then we can deprecate the other two.

Hi @atakaragoz This is a great contribution. We're a little swamped right now so it might be another week or two before we can help with fixing the failing checks,...

When we do this maybe we make a table for extensions and another table for plugins?

Hi @ChristopheBossens Thanks very much for this! I think it is failing right now because package-lock.json isn't up to date. Can you run `npm i --package-lock-only` in the root directory...

We might also want to think about how extensions could work in this scheme. Currently their `info` property is just a name: https://github.com/jspsych/jsPsych/blob/c6a5691c066097922a4911b74706b12f81a83847/packages/extension-webgazer/src/index.ts#L43-L45 Adding version and data to this seems...

@Bankminer78 looks like the extension manager tests need to be updated with new data

Would it make sense to add a parameter to survey-text that turns the feature on/off?

This is a good idea -- it seems like extensions should automatically add their version info to the data file on trials where they are active. Like plugins do.