Fix for GitHub save failing
resolves jocelyn-stericker/hacklily#55, resolves jocelyn-stericker/hacklily#33
Saving to GitHub was failing due to process.env not being available on the client side. Adding a few lines to the webpack.config.js fixes this.
Also, I updated the README.md as the makefile doesn't exist, so the make serve command is outdated? I updated the readme with the commands that (I think) should be run instead. I should note that I was getting an error with yarn build but not with npm run build. The yarn error had something to do with the enhanced-resolve npm plugin and the normalize.css file in src.
Love your work on this, btw. Really nice and useful.
Deploy Preview for hacklily ready!
| Name | Link |
|---|---|
| Latest commit | 6c8bc6fb2cf28cc1491a9def405e6226585efa5b |
| Latest deploy log | https://app.netlify.com/sites/hacklily/deploys/641b6bf5a98d3400084d3537 |
| Deploy Preview | https://deploy-preview-68--hacklily.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Hi, I'm also having trouble saving files, is there a reason preventing this fix to be applied? Thanks :)
Same here. Would be really nice to get this merged @jocelyn-stericker 🙏