react-native-image-viewing icon indicating copy to clipboard operation
react-native-image-viewing copied to clipboard

Feat/optional velocity threshold

Open kanelloc opened this issue 2 years ago • 4 comments

Summary

  • Added a new optional property swipeCloseVelocity to override the default valueSWIPE_CLOSE_VELOCITY

This PR solves the following issue: https://github.com/jobtoday/react-native-image-viewing/issues/165

kanelloc avatar Dec 16 '22 10:12 kanelloc

Hey @antonKalinin 👋 Can you check this PR to solve the attached issue?

Thanks 😄

kanelloc avatar Dec 16 '22 18:12 kanelloc

Hey @maksimko 👋 Can you check this PR to solve the attached issue? Thanks 😆

kanelloc avatar Dec 23 '22 09:12 kanelloc

@kanelloc

I wanted to use your branch, I did this in my packages.json file using yarn "react-native-image-viewing": "kanelloc/react-native-image-viewing#feat/optional_velocity_threshold",

but now the import isn't working. I am importing it like this import ImageView from "react-native-image-viewing";

but I am getting the following error message Cannot find module 'react-native-image-viewing' or its corresponding type declarations.ts(2307)

Do you know why? Thanks

UchennaOkafor avatar Feb 04 '23 16:02 UchennaOkafor

@antonKalinin please merge it

seferdemirci avatar Aug 24 '23 22:08 seferdemirci