react-native-image-viewing icon indicating copy to clipboard operation
react-native-image-viewing copied to clipboard

Published 20 hours ago • verified publisher icon jobtoday

support react-native-web

Open staltz opened this issue 3 years ago • 7 comments

Not a lot of changes are needed in this project to support react-native-web. Solves #82

I tested these changes by publishing a fork @staltz/react-native-image-viewing to npm, and I used it in my app https://github.com/staltz/manyverse and can confirm it's working.

staltz avatar Dec 09 '21 15:12 staltz

Any timeline on getting this approved and merged in? We would like to use this as well.

sealabcore avatar Dec 17 '21 23:12 sealabcore

This would be amazing to have! @antonKalinin any chance of this getting merged?

markymc avatar Feb 14 '22 12:02 markymc

Is there any plans on this being merged?

rickwillcox avatar Oct 31 '22 01:10 rickwillcox

Any update?

gabriel-moresco avatar Dec 19 '22 17:12 gabriel-moresco

It will be very nice to have this support for web merged in. @antonKalinin @maksimko kindly look into this for us. Thanks

samora avatar Aug 21 '23 19:08 samora

Any update? There hasn't been any commits on main for 2 years, should this library be considered as abandoned? :/

Edit: I'm not pressuring anyone, just really trying to understand if forking would be encouraged going forward, or could we expect things to progress here.

sergioisidoro avatar Mar 28 '24 13:03 sergioisidoro

Update - We took a look at @staltz fork and PR. We needed to make one small adjustment[1], but things started to work pretty much right away.

[1] - For some reason this condition was preventing the Modal from showing when visible was true (although the state was correct, and the component was being re-rendered. Perhaps some issue in reconciliation). We're on React 18, react native 0.72 and react native web 0.19.9 https://github.com/jobtoday/react-native-image-viewing/blob/8a91a9c370cb0e6820482b2262aacd1e25a718f7/src/ImageViewing.tsx#L91-L93

It has a bit of a performance penalty, but fixed the issue of the modal not showing for us.

sergioisidoro avatar Apr 03 '24 12:04 sergioisidoro