Johannes Brachem

Results 92 comments of Johannes Brachem

Updated the PR. - Renamed `liesel.model.LogProb` -> `liesel.model.LieselLogProb` (same for the FlatLogProb class) - Added `liesel.goose.LogProb`, which operates on any `gs.ModelInterface`. Simply gives convenient access to log probability, gradient, and...

Also, `gs.engine.stack_for_multi` has been marked as deprecated since v0.1.0, but it is still used in `test_engine.py` and `for_test_summary.py`: ```python # test_engine.py mss = stack_for_multi([ms for _ in range(num_chains)]) ``` ```python...

Thanks! Yep, I'm aware of the failing tests for transform, see the opening text of the PR. They are related to the transformation of weak variables, which is possible with...

With a tiny additional change to Var.transform (since I was touching it anyway), this PR also closes #218

@wiep this can be reviewed. I don't think #263 is necessary anymore.

Turns out, Group deprecation now triggers a lot of warnings, which are promptly turned into errors... maybe they can be resolved quickly.

Well, this is a bit annoying. The `DistregBuilder` relies on Groups more than I thought. The functionality can be covered using https://github.com/liesel-devs/liesel/pull/253 and https://github.com/liesel-devs/liesel/pull/202. But I don't want to port...

> hmm, then we do not turn warnings into errors and resolve the new warnings later? I'd like to keep turning warnings into errors. In this case, that feature already...

> In commit [892547e](https://github.com/liesel-devs/liesel/commit/892547e2641e2d3819cddf0a7902c598744a62ec) this filter works for me `"ignore:*Deprecated in v.0.4.0. Will be removed in a future release.*:FutureWarning",` > > I think it makes sense to have a filter...

@wiep could you have a look at the pytest warning? It did not show up before, because pymc was not being installed in the test hooks after the switch to...