TbSync icon indicating copy to clipboard operation
TbSync copied to clipboard

add If-None-Match

Open jotisk opened this issue 5 years ago • 3 comments

Your environment

TbSync version: 2.12 beta Thunderbird version: 68.8.0

[x ] Yes, I have installed the latest available beta version from https://tbsync.jobisoft.de and my issue is not yet fixed, I can still reproduce it.

Expected behavior

Sync carddav on zimbra server ...

Actual behavior

zimbra server returns 409 because If-None-Match header is missing (even it is not mandatory in RFC) ...

Steps to reproduce

put contact to zimbra server ...

Is possible to add If-None-Match header for contact create requests? Zimbra server requires it in older version (8.0.6 and I dont have possibility to update server at moment) . Thank you.

jotisk avatar May 11 '20 09:05 jotisk

Can you contribute a patch?

Am 11.05.2020 um 11:44 schrieb jotisk [email protected]:

Your environment

TbSync version: 2.12 beta Thunderbird version: 68.8.0

[x ] Yes, I have installed the latest available beta version from https://tbsync.jobisoft.de and my issue is not yet fixed, I can still reproduce it.

Expected behavior

Sync carddav on zimbra server ...

Actual behavior

zimbra server returns 409 because If-None-Match header is missing (even it is not mandatory in RFC) ...

Steps to reproduce

put contact to zimbra server ...

Is possible to add If-None-Match header for contact create requests? Zimbra server requires it in older version (8.0.6 and I dont have possibility to update server at moment) . Thank you.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

jobisoft avatar May 11 '20 09:05 jobisoft

unfortuantely I'm unable to patch it, When I modified DAV-4-TBSync file sync.js , line 862 then TBsync reports that DAV4TBsync is not installed. Anyway change would be : let headers = {"Content-Type": "text/vcard; charset=utf-8, If-None-Match": vcard.etag};

header is required for both, updated and new items.

jotisk avatar May 11 '20 10:05 jotisk

Shifted to TB78

jobisoft avatar Jun 15 '20 20:06 jobisoft

Switching to native CardDAV sync and removing my own sync code.

jobisoft avatar Sep 21 '22 08:09 jobisoft