Job Evers

Allow fallback to 'id' key

2

If identity is a dictionary, `identity = getattr(identity, 'id') or identity['id']` fails with `AttributeError: 'dict' object has no attribute 'id'` Setting the default allows the `id` key to be used.

The [current docs](https://pythonhosted.org/Flask-JWT/index.html#flask_jwt.JWT.authentication_handler.) specify that the authentication handler "should return an object representing an authenticated identity." but its not clear what exactly that means. Digging into [the](https://github.com/mattupstate/flask-jwt/blob/c27084114e258863b82753fc574a362cd6c62fcd/flask_jwt/__init__.py#L62) [source](https://github.com/mattupstate/flask-jwt/blob/c27084114e258863b82753fc574a362cd6c62fcd/flask_jwt/__init__.py#L53) I can...

document freeSlideBehind option

2

I'm not sure what freeSlideBehind is for: https://github.com/gre/diaporama/blob/80e977ce03ac194fc8b9ce149b809f43a0bef522/lib/Diaporama.js#L210

allow utf8 characters in git commit messages

3

Fixes https://github.com/nylas/make-deb/issues/13

support dh-virtualenvs arguments

1

dh-virtualenv has a bunch of command line flags that it can take: http://dh-virtualenv.readthedocs.io/en/latest/usage.html It would be nice if make-deb could support those.

make-deb fails if the latest_git_commit contains unicode

4

If the latest git commit message has unicode in it, this line https://github.com/nylas/make-deb/blob/master/make_deb/__init__.py#L95 will throw a UnicodeDecode error.

The spec says that `exists()` takes in `**kwargs`: https://filesystem-spec.readthedocs.io/en/latest/_modules/fsspec/spec.html#AbstractFileSystem.exists but https://github.com/fsspec/adlfs/blob/main/adlfs/spec.py#L1368 does not.