sly icon indicating copy to clipboard operation
sly copied to clipboard

How to show images in the SLY's REPL?

Open svetlyak40wt opened this issue 2 years ago • 8 comments

For SLIME there is a slime-media contrib with slime-media-insert-image which can be used like this: https://github.com/pszer/emacs-slime-image

But for SLY I can't find anything like that. Am I'm missing something?

svetlyak40wt avatar Mar 14 '24 12:03 svetlyak40wt

@joaotavora what do you think?

svetlyak40wt avatar Apr 04 '24 13:04 svetlyak40wt

I think it's a fine idea, but SLIME's contrib isn't immediately compatible, so you need to make something that plugs into sly-mrepl.el and sly-mrepl.lisp. I'd make a new contrib. You can make an in-tree contrib (under contribs/) or an out-of-tree one (using the sly-hello-world template).

Make this one as an in-source one, i.e. as a PR. That's because you will probably need to change bits of sly-mrepl.el and sly-mrepl.lisp. Good luck, I can't help you much. Maybe @aadcg can accompany you in this work.

joaotavora avatar Apr 04 '24 13:04 joaotavora

@joaotavora I think I could contribute some time to maintain SLY, since it seems clear that it's hard for you to be on top of everything.

Regarding this issue in particular, I'd be happy to review it, but I'm not keen on working on it.

Greetings @svetlyak40wt, hope you're doing well.

aadcg avatar Apr 04 '24 14:04 aadcg

@aadcg yes. I'll send you an invitation. Be careful, last I heard project is used in production by many good friends :-) Shoot me a mail if in doubt about anything.

joaotavora avatar Apr 04 '24 15:04 joaotavora

André, feel free to list yourself as current maintainer (or Co-Maintainer maybe) in the relevant source files and in appropriate forums.

joaotavora avatar Apr 04 '24 15:04 joaotavora

Thank you guys! I'll try to implement this contrib some day!

svetlyak40wt avatar Apr 04 '24 15:04 svetlyak40wt

@joaotavora thanks! I'll add myself as a co-maintainer as soon as I have done some meaningful work. For the time being, I can't contribute much time but hopefully some.

I'll always ping you when in doubt, and maintain a rather conservative posture.

aadcg avatar Apr 04 '24 19:04 aadcg

@svetlyak40wt Good news! I just implemented what you want :) Thanks for bringing up this request: https://github.com/joaotavora/sly/pull/638

Please try it out and let me know what you think.

jcguu95 avatar Apr 22 '24 22:04 jcguu95