sly icon indicating copy to clipboard operation
sly copied to clipboard

add support for company-kind

Open jidibinlin opened this issue 2 years ago • 5 comments

If we add company-kind support. completion front end such as corfu can get the kind information to implement more feature. For my purposes I can use it to make corfu support icon display when pop up the completion frame.

image

jidibinlin avatar Nov 03 '22 09:11 jidibinlin

Looks good in principle, but please remove unrelated whitespace changes first.

joaotavora avatar Nov 03 '22 13:11 joaotavora

Alright, But I suggest you automatically delete whitespace when you save buffer. I will remove unrelated whitespace changes.

jidibinlin avatar Nov 04 '22 01:11 jidibinlin

@joaotavora please check it. Happy hacking.

jidibinlin avatar Nov 04 '22 02:11 jidibinlin

@joaotavora This pr can be merged?

jidibinlin avatar Nov 11 '22 11:11 jidibinlin

No it needs better commit messages and better formatting. I don't have time right now so be patient. The idea is good. Maybe you can guess from other commits the coding standards

joaotavora avatar Nov 11 '22 11:11 joaotavora

Fairly sure, this was fixed in https://github.com/joaotavora/sly/pull/634. So closing. Thanks.

joaotavora avatar May 12 '24 23:05 joaotavora