João Távora
João Távora
> defining classes for each of the event types? No we can't do that. But you can just add an :around. It's just as effective as a hook. But maybe...
@monnier or @aadcg feel free to apply the patch with a suitable commit message, if this is successfully tested. It seems `function` should be renamed `collection` in `sly--completion-in-region-function`
> However won't this circumvent all the nice features of sly-symbol-completion-mode? It might. You're the only one testing it, afaik. Can you tell us which features you suspect or observe...
> modified function does not produced *sly-completions* buffer which has the additional information about the the type of the symbol etc. This is a no-go, unless this behaviour is recovered...
IOW, people using SLY as they have been for many years shall not be impacted by this patch.
Ii completely redesigned my part and should be now much cleaner. I tested on my config and was OK, though the Travis build still fails. Have to investigate. Lets continue...
OK, I understand why it failed. I tested on allegro and used some allegrisms there. WIll look at it later.
@fare, yes I agree. I am only waiting for @easye to confirm that it was that commit that broke it.
@easye see commit 6aafda8, it should rollback the swank.asd parts to the previous version and fix your problems.
Yeah, I rolled back the whole file, typos included...