gulp-atom-electron icon indicating copy to clipboard operation
gulp-atom-electron copied to clipboard

Downloading from custom repo always downloads electron.zip

Open joaomoreno opened this issue 4 years ago • 1 comments

The adoption to download ffmpeg and other components was never adopted in: https://github.com/joaomoreno/gulp-atom-electron/blob/2f2994f9f2604b92d4032f66d8c6931b4e392265/src/util.js#L10-L10

cc @deepak1556, related to https://github.com/joaomoreno/gulp-atom-electron/pull/59

joaomoreno avatar Jan 25 '21 14:01 joaomoreno

I seriously can't believe how hard it is to get the latest gulp-atom-electron to work on VS Code.

I have adopted the mirror option: https://github.com/joaomoreno/gulp-atom-electron/commit/d4e068799834ab6155fc1d9fb3bba512984f999f

But now authentication doesn't seem to work at all, and that's a problem given our private electron repo. Even after setting everything correctly: https://github.com/joaomoreno/gulp-atom-electron/commit/9bc9b5252418160b7361ed2d55c226199bbc2497

To be continued...

joaomoreno avatar Jan 25 '21 16:01 joaomoreno