JoinDesktop icon indicating copy to clipboard operation
JoinDesktop copied to clipboard

Published 20 hours ago • verified publisher icon joaomgcd

SMS issues

Open tommyent opened this issue 5 years ago • 9 comments
trafficstars

Haven't tried to look at things but I had this from the other day and is still an issue Trace: TypeError: Cannot read property 'address' of undefined at ControlSMSConversation.renderCurrentSmsConversation (file:///Applications/Join%20Desktop.app/Contents/Resources/app.asar/v2/sms/conversation/controlsmsconveration.js:125:89) at async ControlSMSConversation.setSmsConversation (file:///Applications/Join%20Desktop.app/Contents/Resources/app.asar/v2/sms/conversation/controlsmsconveration.js:89:9) at async AppHelperSMS.reloadConversationFromNetwork (file:///Applications/Join%20Desktop.app/Contents/Resources/app.asar/v2/sms/apphelpersms.js:153:9) at async AppHelperSMS.switchToConversation (file:///Applications/Join%20Desktop.app/Contents/Resources/app.asar/v2/sms/apphelpersms.js:148:9) at async AppHelperSMS.setMode (file:///Applications/Join%20Desktop.app/Contents/Resources/app.asar/v2/sms/apphelpersms.js:77:13)

Also Screen Shot 2020-07-28 at 1 55 09 PM should be Screen Shot 2020-07-28 at 1 56 03 PM

Not sure if this has anything to do with RCS

tommyent avatar Jul 28 '20 18:07 tommyent

Thanks! Probably an issue with MMS. Haven't had a chance to test those yet (my network makes it hard and expensive to use those).

Do you get that error every time an MMS is in the conversation?

joaomgcd avatar Jul 29 '20 07:07 joaomgcd

The undefined address happens with or without MMS the [Urgent!] MESSAGE_SUBJECT is every MMS

tommyent avatar Jul 29 '20 15:07 tommyent

Ok, think this is fixed. Can you please check?

joaomgcd avatar Jul 30 '20 10:07 joaomgcd

Images are still missing. There is now no indication of an image at all. Screen Shot 2020-07-30 at 12 46 22 PM

tommyent avatar Jul 30 '20 16:07 tommyent

Yeah, unfortunately I wasn't able to test images yet solely because I have no way to get MMS on my phone right now :/ Need to find a way to do that soon...

joaomgcd avatar Aug 05 '20 14:08 joaomgcd

What's the issue with getting MMS on your phone? Is it a service provider issue?

tommyent avatar Aug 05 '20 15:08 tommyent

Yeah, MMS aren't really used here so I don't even have a way of sending them to myself :/

joaomgcd avatar Aug 05 '20 15:08 joaomgcd

Well the best I can do is offer to test commits. I thought there were test SMS/MMS gateways that you can use outside your provider so I will take a look. Slowly we are being moved to RCS however for the rest of the world I don't think they care.

tommyent avatar Aug 11 '20 17:08 tommyent

Yeah... I need to try and replicate the code in the Chrome extension cause that's working. I just don't have a way to test it right now :P

joaomgcd avatar Aug 12 '20 08:08 joaomgcd