DateTimeExtensions
DateTimeExtensions copied to clipboard
joaomatossilva
Indian Holiday
@joaomatossilva This contains 2 files on Indian Holidays. It has both Strategies and Tests. This is based on Chinese Calendar files since Both follow the Lunisolar Calendar system.
It contains a few among many holidays, I have added the most prominent 6 of the festivals.
I was wondering why the Build was not working, but then I found that Indian Holidays were already implemented 7 years ago: https://github.com/joaomatossilva/DateTimeExtensions/blob/master/src/DateTimeExtensions/WorkingDays/CultureStrategies/IndianHolidayStrategy.cs
maybe you could update that strategy with yours, if it's more complete
you can visualize it here: https://datetimeextensions.azurewebsites.net/Calendar/en-IN/2024
I was wondering why the Build was not working, but then I found that Indian Holidays were already implemented 7 years ago: https://github.com/joaomatossilva/DateTimeExtensions/blob/master/src/DateTimeExtensions/WorkingDays/CultureStrategies/IndianHolidayStrategy.cs
maybe you could update that strategy with yours, if it's more complete
I checked the code and i had updated more holidays than whats given. So I can update that and make a PR w.r.t that code.
Sorry I was out of touch. I will be making the following changes to get this PR complete.
- deleting the files i put and replace with previously present ones in the same location IndianHoliday ones to avoid repitition.
- I will be changing the files and adding some more holidays. Indian Holidays has some government set National Holidays(will be present), fixed festive holidays(some present) and optional festive holidays(not present in updated code)
Net 3 files would be added as before.
You can remove it
On Sun, May 26, 2024, 11:30 Anirudh Gupta @.***> wrote:
Oh by the way, i noticed. the original indian holiday file has #region License Is it possible to change it??? :{|
— Reply to this email directly, view it on GitHub https://github.com/joaomatossilva/DateTimeExtensions/pull/153#issuecomment-2132168558, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC5GFQYSXDAFHPWZJZOEBDZEG2STAVCNFSM6AAAAABDTI5OUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZSGE3DQNJVHA . You are receiving this because you were mentioned.Message ID: @.***>
@AnirudhG07 Can you rebase and check the failing automatic tests? Can't merge this if the build is not green