bitwarden-ssh-agent icon indicating copy to clipboard operation
bitwarden-ssh-agent copied to clipboard

New Features

Open hasechris opened this issue 2 years ago • 1 comments

Hi @joaojacome,

up to now i used KeepassXC, which got synced via nextcloud to all my devices. Now i moved to a "real" selfhosted passwordsafe solution (vaultwarden) and wanted to have the same flexibility as with my KeepassXC setup regarding the ssh key management.

Searching the internet i found your github repo in the bitwarden forum. I tested it and was initially happy, but i missed a bit of the convenience of the KeepassXC sshkey handling. So i added the features i was missing.

New features from me:

  • specify entryname instead of iterating over all entries from folder
  • remove an entry from ssh-agent
  • allow usage of password field as key password
  • assume flag which tells the script to use the entryname as the keyname (name of attachment in bitwarden), so no customfield is needed.

Also i merged the solution from #29 from @Weidows before all my development into my new fork, because i needed to specify the session token as the env variable was not always working in my case. Hope this is not a problem regarding merge conflicts.

Additionally i want to extend usage documentation regarding how i use shell aliases so the user is only specifying the parameters he absolutly has to. I could not find the right spot for that part, so it isn't part of this PR yet.

IMPORTANT: I would be relieved if someone could check my python programming. Im literally new to python in general (this is my second python script on which im working in my entire life).

Best regards hasechris

hasechris avatar Jan 09 '23 01:01 hasechris

Hi @hasechris,

Thanks for the contribution.

I'll take a look at your changes and I'll get back to you.

joaojacome avatar Jan 14 '23 11:01 joaojacome