rust_sqlite icon indicating copy to clipboard operation
rust_sqlite copied to clipboard

Rethink of project logic

Open joshbenaron opened this issue 3 years ago • 3 comments

Hey, I was just starting to implement the SELECT query of the engine and I guess I've been thinking about the overall approach. At the moment it seems to be very modular (which isn't actually bad when it comes to abstracting over the engine). Parse query -> Parse to structs -> Execute. I think we should remove the middle step and go straight to execution. This would mean fewer allocations along the line. So basically take sqlparser's output and just use that in execution I'd love to know what you think.

joshbenaron avatar May 31 '21 00:05 joshbenaron

I like the idea of having fewer allocations. Definitely decreasing possible failure points.

Btw, I created a discord server for the project so we can start have a more active conversation and build a community. Here is the link: https://discord.gg/zHXUG66X .

joaoh82 avatar Jun 14 '21 13:06 joaoh82

I like the idea of having fewer allocations. Definitely decreasing possible failure points.

Btw, I created a discord server for the project so we can start have a more active conversation and build a community. Here is the link: https://discord.gg/zHXUG66X .

@joaoh82 Hey sorry, I just saw this. Can you send an updated link, please?

joshbenaron avatar Jun 29 '21 16:06 joshbenaron

Hi @joshbenaron , here you go.

https://discord.gg/NRtpsvEDyS

joaoh82 avatar Jun 29 '21 17:06 joaoh82