reactive_forms icon indicating copy to clipboard operation
reactive_forms copied to clipboard

feat: update RequiredValidator to support validate empty Map, List, S…

Open simonpham opened this issue 1 year ago • 4 comments

simonpham avatar Aug 13 '24 07:08 simonpham

/gemini review

joanpablo avatar Jun 14 '25 05:06 joanpablo

Hi @simonpham Thank you for the PR, really appreciate it. If possible would you mind to address the suggestions whenever you have the time?

joanpablo avatar Jun 14 '25 05:06 joanpablo

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 95.40%. Comparing base (31e3018) to head (54cc8c5). Report is 36 commits behind head on master.

Files with missing lines Patch % Lines
lib/src/validators/required_validator.dart 33.33% 4 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #460      +/-   ##
==========================================
+ Coverage   95.02%   95.40%   +0.38%     
==========================================
  Files          67       66       -1     
  Lines        1386     1394       +8     
==========================================
+ Hits         1317     1330      +13     
+ Misses         69       64       -5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jun 14 '25 21:06 codecov[bot]

Hi @simonpham It seems like there are still some issues to solve in the PR after the change. Plase take a look whenever you have the time, and let me know if you have any questions. Thanks in advance.

joanpablo avatar Jun 15 '25 16:06 joanpablo