cl-webkit icon indicating copy to clipboard operation
cl-webkit copied to clipboard

Deprecated javascript methods

Open aadcg opened this issue 10 months ago • 0 comments

Just a heads-up as it may bite in the future.

https://webkitgtk.org/reference/webkit2gtk/stable/method.WebView.run_javascript_in_world.html

diff --git a/webkit2/webkit2.web-view.lisp b/webkit2/webkit2.web-view.lisp
index 6c1ab66..d17ec5c 100644
--- a/webkit2/webkit2.web-view.lisp
+++ b/webkit2/webkit2.web-view.lisp
@@ -233,6 +233,7 @@ defcfun "webkit_web_view_get_is_muted"
 #+webkit2-mute
 (export 'webkit-web-view-get-is-muted)
 
+;; Deprecated since 2.40, use webkit_web_view_evaluate_javascript instead.
 (defcfun "webkit_web_view_run_javascript" :void
   (web-view (g-object webkit-web-view))
   (script :string)
@@ -241,6 +242,7 @@ defcfun "webkit_web_view_run_javascript"
   (user-data :pointer))
 (export 'webkit-web-view-run-javascript)
 
+;; Deprecated since 2.40, use webkit_web_view_evaluate_javascript instead.
 (defcfun "webkit_web_view_run_javascript_in_world" :void
   (web-view (g-object webkit-web-view))
   (script :string)
@@ -303,6 +305,7 @@ defun webkit-web-view-evaluate-javascript
        (cffi:make-pointer callback-counter))))
 (export 'webkit-web-view-evaluate-javascript)
 
+;; Deprecated since 2.40, use webkit_web_view_evaluate_javascript_finish instead.
 (defcfun ("webkit_web_view_run_javascript_finish" %webkit-web-view-run-javascript-finish) webkit-javascript-result
   (web-view (g-object webkit-web-view))
   (result g-async-result)
@@ -313,6 +316,7 @@ defun webkit-web-view-run-javascript-finish
     (%webkit-web-view-run-javascript-finish web-view result err)))
 (export 'webkit-web-view-run-javascript-finish)
 
+;; Deprecated since 2.40, use webkit_web_view_evaluate_javascript instead.
 (defcfun "webkit_web_view_run_javascript_from_gresource" :void
   (web-view (g-object webkit-web-view))
   (resource :string)
@@ -321,6 +325,7 @@ defcfun "webkit_web_view_run_javascript_from_gresource"
   (user-data :pointer))
 (export 'webkit-web-view-run-javascript-from-gresource)
 
+;; Deprecated since 2.40, use webkit_web_view_evaluate_javascript_finish instead.
 (defcfun ("webkit_web_view_run_javascript_from_gresource_finish" %webkit-web-view-run-javascript-from-gresource-finish) webkit-javascript-result
   (web-view (g-object webkit-web-view))
   (result g-async-result)
@@ -531,6 +536,7 @@ defun webkit-web-view-can-execute-editing-command
    (cffi:make-pointer callback-counter)))
 (export 'webkit-web-view-can-execute-editing-command)
 
+;; Deprecated since 2.22, use jsc_value_get_context instead.
 (defcfun "webkit_web_view_get_javascript_global_context" js-global-context-ref
   (web-view (g-object webkit-web-view)))
 (export 'webkit-web-view-get-javascript-global-context)
@@ -543,11 +549,12 @@ defcfun "webkit_javascript_result_unref"
   (js-result webkit-javascript-result))
 (export 'webkit-javascript-result-unref)
 
+;; Deprecated since 2.22, use jsc_value_get_context instead.
 (defcfun "webkit_javascript_result_get_global_context" js-global-context-ref
   (js-result webkit-javascript-result))
 (export 'webkit-javascript-result-get-global-context)
 
-;; Deprecated, use webkit-javascript-result-get-js-value instead.
+;; Deprecated since 2.22, use webkit_javascript_result_get_js_value instead.
 (defcfun "webkit_javascript_result_get_value" js-value-ref
   (js-result webkit-javascript-result))
 (export 'webkit-javascript-result-get-value)

aadcg avatar Sep 01 '23 12:09 aadcg