Jonas Nyrup

The api and implementation are both straight forward, but my immediate gut feeling is that it will only be needed/used by a few. If you haven't done it already, you...

#1469 prevents it from throwing an OOM, so the _main_ problem is solved ✅ There are still related things that would be nice to improve when formatting complex object graphs,...

Ahhh, that's why I initially added the milestone. If we omit the internal members from the failure message, then it becomes inconsistent with `BeEquivalentTo` which _do_ include `internal` members as...

The work about internal members is also tracked in #744 and #1205

With the current xunit, you can get the best of both worlds. https://github.com/fluentassertions/fluentassertions/blob/97d737e89043cec5b3291aeb321fa1cb14f3c457/Tests/Shared.Specs/ExceptionAssertionSpecs.cs#L29-L36

Without having looked at the code and thought more about potential edge cases, it sounds reasonable to me to add check on `task.IsCompleted`.

Sorry for being late at the party. The bug here seems to stem from ```c# EqualityStrategy IEquivalencyAssertionOptions.GetEqualityStrategy(Type type) { EqualityStrategy strategy; if (referenceTypes.Any(type.IsSameOrInherits)) { strategy = EqualityStrategy.ForceMembers; } ``` where...

@ursenzler When you get around testing against your codebase the fix has been merged to `develop`.

I have a case that could be more readable with `ThatAreAbstract`. Aside from that one, I currently don't any of these methods myself. Let's discuss on Slack how I be...

@ursenzler Glad to hear it worked out. You can close #1383 Regarding `EquivalencyAssertionOptionsExtensions`: > Strictly speaking this a breaking change as the class is `public`. > I don't think anyone...