nunes icon indicating copy to clipboard operation
nunes copied to clipboard

Abstract to more natively support datadog

Open jnunemaker opened this issue 7 years ago • 5 comments

Datadog has tags (e.g. foo tagged bar and bar) and does not have glowing of metrics based on metric parts (e.g. foo.bar.* doesn't work). Currently the instrumentation is just a metric name and value. It would be nice to abstract this somehow to support metric name/value and metric name/tag style storage. Likely wouldn't be hard, but figured the first step is to write up an issue.

jnunemaker avatar Feb 08 '18 21:02 jnunemaker

do you think the approach taken in this commit:

https://github.com/jacobbednarz/nunes/commit/f9dc38a7baea9415558d5a6db535b40a6e908010

is okay? I do not know the author but I am interested in this feature and can spend the time to implement it if you do not find the approach the above commit is taking. I also don't know the author of that commit, found it while scrubbing the internet.

bjhaid avatar Jun 01 '18 13:06 bjhaid

@bjhaid hi! I'll be honest and say that I haven't thought it all through. Something like that could work though.

jnunemaker avatar Jun 27 '18 18:06 jnunemaker

Thanks for getting back, please do reach out when you have more formed thoughts around this, thanks!

bjhaid avatar Jun 27 '18 22:06 bjhaid

I have an interest in this feature and I'd be willing to help. I don't want to step on anyone's toes if you're actively workin on this at all. Please let me know if I could help here!

armilam avatar Jul 16 '18 17:07 armilam

@armilam no toe stepping. Go for it!

jnunemaker avatar Jul 24 '18 21:07 jnunemaker