crack
crack copied to clipboard
Crack breaks Mongoid by adding #attributes method to the String class
Crack adds the #attributes method to the String class when parsing xml which conflicts with Mongoid as Mongoid uses respond_to?(:attributes) when determining whether to load associations.
Crack should likely not be adding #attributes to String. It should use a wrapper class or a subclass if it needs to modify core classes with something library specific.
The issue can be seen in this commit:
https://github.com/jnunemaker/crack/commit/be463a10929cc8acea1328fb8b47f9f73e3645f3
Not yet pulled in, but fixed by a patch here that hasn't been pulled in https://github.com/jnunemaker/crack/pull/25 & by a mongoid patch here https://github.com/mongoid/mongoid/issues/618 that hasn't been pulled either
It seems to be fixed already. Feel free to reopen the issue if you think otherwise