John Nunemaker

Results 132 comments of John Nunemaker
trafficstars

I barely remember. This was from a long time ago. I believe the goal was to add a proxy to the parsed response in order to expose the status code...

Sounds like some weird thread issue, maybe the fact that the body is lazy loaded using ||= or something? I don't know.

Pretty sure the if was added to fix some issue. Maybe it only affected older versions of ruby?

@Nechitadi I can't replicate this. Can you get me a failing script or spec? If you change the uri adapter to addressable does it work? ```ruby uri_adapter(Addressable::URI) ```

Yep, you’ll need a base service or another include that sets the uri adapter.  Must be Ruby’s uri has an issue with this as that is the default uri adapter. ...

I think I'm in favor of this. It very likely could break a lot of people's use but feels like the right thing. I believe I added nil? (if it...

If so, only by luck. There has been no intentional thread safe work, though I would be extremely open to pull requests toward this goal.

No update. I do not do much multi threaded stuff so I’m not the best person to work on this.

@TheSmartnik I still don't really get the BOM stuff so do what you think is right. If things blow up we can always revert and release a new version.