John Nunemaker

Interesting! Let’s decide on it next week. Only other concern is one more thing to search for when finding flag usage.

Seeing #783 made me think if we do this PR we could also add flipper_features to return all enabled features for an actor or a Hash of all features with...

@bkeepers I was going through old PRs today. I say we merge this and see if people like it.

@MagoMathew thanks! This looks good. I've been mostly off for the holidays. Sorry for slow response. Only thing I'm trying to decide on is if we should roll with what...

> I'm thinking we should add threadsafe? to the adapter API and change Flipper to reuse adapter instances of threadsafe adapters. @bkeepers I like this idea.

@bkeepers anything left on this? It seems like you've responded to all the feedback. Do we just need someone to guinea pig in production somewhere?

@gstokkink sure. I'd just make a new adapter for it and specs. You can start by cloning the current redis one or taking a peek at the redis cache one....

Generally I’d say we don’t support versions that are EOL by rails but checking if the app responds to credentials seems easy. Any interest in a PR?

I think my only issue with this is the inheriting from memorizable and turning memoize off. It might be just because I haven't started from scratch on it to see...

Memoizable usually just sits in front and falls back to the original adapter. So if your original falls back to in memory cache it should just work. Maybe something else...