UpSetPlot icon indicating copy to clipboard operation
UpSetPlot copied to clipboard

matplotlib.tight_layout restricts matplotlib version to 3.5.2

Open ilibarra opened this issue 1 year ago • 3 comments

Dear UpSetPlot team,

On an issue related to matplotlib in this repository, I am asking whether this dependency limitation of matplotlib to version 3.5.2 can be considered and fixed to handle matplotlib >=3.6 https://github.com/theislab/superexacttestpy/issues/18

Thank you,

ilibarra avatar Sep 22 '22 09:09 ilibarra

I am not able to get it to work with even matplotlib==3.5.2 - does this work for you @ilibarra?

0xharib avatar Sep 27 '22 11:09 0xharib

@0xharib thanks for input. While importing I get no errors when using 3.5.3 (below). The test with 3.5.2 was done by another user, and I can verify it again if you want.

Thank you for additional input and handling this error. Me and others can help finding the source if difficult to detect error/fix it.

rio@NB085081:ignacio.ibarra$ ipython
iPython 3.8.13 (default, Mar 28 2022, 11:38:47) 
Type 'copyright', 'credits' or 'license' for more information
IPython 8.4.0 -- An enhanced Interactive Python. Type '?' for help.
In [1]: import matplotlib
In [2]: matplotlib.__version__
Out[2]: '3.5.3'
In [3]: import upsetplot
In [4]:

ilibarra avatar Sep 28 '22 20:09 ilibarra

I also run into an error on matplotlib 3.6:

from matplotlib.tight_layout import get_renderer
ImportError: cannot import name 'get_renderer' from 'matplotlib.tight_layout'

jbloom avatar Sep 29 '22 18:09 jbloom

Hello - I am getting the exact same error with matplotlib 3.6.1 despite the fix that is mentioned (#192 )?

import upsetplot
ImportError: cannot import name 'get_renderer' from 'matplotlib.tight_layout'

andrewjkwok avatar Oct 26 '22 23:10 andrewjkwok

Yeah - the Pull Request (#192) was not yet approved by @jnothman .

GuyTeichman avatar Nov 08 '22 08:11 GuyTeichman