dsteem icon indicating copy to clipboard operation
dsteem copied to clipboard

Published 20 hours ago • verified publisher icon jnordberg

add prepare script to support installing from git

Open sneak opened this issue 5 years ago • 3 comments

see also

https://github.com/npm/npm/issues/3055

https://github.com/steemit/steem-js/pull/415

sneak avatar Oct 24 '18 11:10 sneak

Wouldn't this run the build for every npm install (even if they are installing from a tarball)?

jnordberg avatar Nov 19 '18 15:11 jnordberg

Maybe? I’m not sure, but in any case I don’t see any harm in that. The problem is that without this, it’s impossible to install directly via git/hash/branch in a package.json.

sneak avatar Nov 19 '18 18:11 sneak

It matters because it adds a considerable amount of install time and it will also pull in the devDependencies for every install. Not to mention that running a separate npm install within an already running npm install is asking for trouble.

I'm trying to decipher https://docs.npmjs.com/misc/scripts and it seems like the new prepare is just an alias for the old publish? But the prepack hook seems to be what we want, maybe?

jnordberg avatar Nov 20 '18 14:11 jnordberg