Jann Launer

Results 107 comments of Jann Launer

The points @c-moeller makes are correct. In case of expandable, capacity is the existing capacity. This is true for all oemof.tabular facades. If this is not well explained in the...

> As far as I understand the stratified thermal storage facade has the parameter `efficiency`. In the examples I found that `stratified_thermal_storage.csv` holds the parameters `inflow_conversion_factor` and `outflow_conversion factor`. You...

> 1. The example names all start with 'stratified_thermal_storage_...', I agree. Let's drop the beginning 'stratified_thermal_storage_'. > 1. If possible the name of the examples should be more speaking. Some...

Which exact function do you mean? `calc_cops()` works fine with pd.Series, already: ``` python import pandas as pd from oemof.thermal.compression_heatpumps_and_chillers import calc_cops periods = 24 datetimeindex = pd.date_range('2020-01-01', periods=periods, freq='H')...

But it returns a list, not a Series. Is that what you meant?

If we find an easy way to allow for Series and lists, that would be a nice feature.

Are you sure that works with nominal value? I just tested it, and it fails with nominal_value as list or Series. ``` python import pandas as pd from oemof.solph import...

Other parameters like `max` accept both scalars and lists or series (numeric (sequence or scalar)) . Scalars are converted to sequences in the background (plumbing.py module).

> The docstring should be something like > > ``` > ... > max : numeric (sequence or scalar) - sequence must be iterable (instance of abc.Iterable) except str >...