cl-qrencode icon indicating copy to clipboard operation
cl-qrencode copied to clipboard

Published 20 hours ago • verified publisher icon jnjcc

Performance optimizations.

Open phmarek opened this issue 5 years ago • 7 comments

Together these changes reduce run time by about 50%, and similarly reduce consing to about 40%. Please take a look and check whether they work for you; my minimal testing was successful.

The biggest remaining offender is EVALUATE-FEATURE-2 - but I'm not sure I understand what this is checking, so I'm not up to modifying that.

Thank you!

phmarek avatar May 21 '19 10:05 phmarek

Forgot a bugfix commit, sorry - included in the force-push.

phmarek avatar May 21 '19 11:05 phmarek

Thanks for your help!

I have not been active on github lately, will look into it

jnjcc avatar Jul 02 '19 10:07 jnjcc

ping...

phmarek avatar Jul 27 '20 09:07 phmarek

Hi!

I just stumbled upon all that again...

Looking at the tests (to find out about the failing test mentioned in #11) I found that your 0de2d8a3877b499a9a0bbb0a9e1247056ae4311e doesn't compile cleanly, the test functions use a wrong function signature ;/

Well, I fixed my perf branch for current SBCL (the :initform type test change); in 6fd84ed3a770ec2882ef2319225c2bc89ebf4713 you can find a test script with some (old) results.

Should we just disable the failing test if no-one knows what it's about?

phmarek avatar Dec 22 '20 07:12 phmarek

ping?

phmarek avatar Feb 11 '21 13:02 phmarek

WOW, long time no see!

I have been busy at work and have been away from github for sooo long, will definitely look into this!

Thanks again for your help

jnjcc avatar May 25 '21 13:05 jnjcc

I'm also pondering to change the bit-lists into a bit-array - or to use bignum support to avoid all the bit-list fiddling at all.

See also https://gist.github.com/jdz/3831dc3b5af5cb76b18b14384216913c.

phmarek avatar May 25 '21 14:05 phmarek