OctoPrint-Tasmota icon indicating copy to clipboard operation
OctoPrint-Tasmota copied to clipboard

Odd Tab Behavior with TouchUI

Open darkgrue opened this issue 3 years ago • 11 comments

I've recently added a Sonoff S31 that I've flashed with Tasmota and installed the Tasmota plug-in for OctoPrint, but I'm seeing some really odd UI behavior in TouchUI that I'm not sure why it's happening. Three tabs get added to the hamburger menu, two titled "Tasmota" (the first shows the power/cost/etc. graph, the second is a blank page), the third tab is just the icon switch toggle (and doesn't switch pages, it functions exactly like the status bar icon in the full UI).

Screenshot 2021-09-10 113647

I suspect it gets worse when you have more than one Tasmota device set up, I only have the one right now. But the blank tab is definitely odd. I assume part of it is how TouchUI fiddles things, but is there an issue on the plug-in side as well?

darkgrue avatar Sep 10 '21 16:09 darkgrue

I assume you cross-posted an issue to TouchUI repo as well? The one that shows the graph is moved into there from a tab, the other one is probably the sidebar where you can toggle the idle timeout value, and then obviously the one with the correct icon is the navbar button.

jneilliii avatar Sep 10 '21 17:09 jneilliii

I assume you cross-posted an issue to TouchUI repo as well? The one that shows the graph is moved into there from a tab, the other one is probably the sidebar where you can toggle the idle timeout value, and then obviously the one with the correct icon is the navbar button.

I hadn't, because I wasn't sure what was actually happening. It sounds like this is a side-effect of what TouchUI does, and maybe a feature request is needed to be able to suppress certain behavior, either by configuration of TouchUI, or plug-ins can programmatically give hints to tell TouchUI to handle things differently...

I'll post it to TouchUI as well, and cross-ref them. Thanks!

darkgrue avatar Sep 10 '21 18:09 darkgrue

Opened https://github.com/BillyBlaze/OctoPrint-TouchUI/issues/512 as well.

darkgrue avatar Sep 10 '21 18:09 darkgrue

Thanks. I had requested this type of touchui plugin handling config before but it never got anywhere and Billy just kept patching for conflicts by not loading or blocking certain plugins. I've programmed workarounds for touchui before, but not sure if this is a case in which I could do that, specifically for the sidebar header toggle switch.

jneilliii avatar Sep 10 '21 22:09 jneilliii

No worries, just wasn't sure which end of the problem to work first! Working both makes more sense, of course... =)

darkgrue avatar Sep 11 '21 01:09 darkgrue

Well, the TouchUI issue was closed without any action or comment, so I guess nothing has changed there.

darkgrue avatar Oct 03 '21 02:10 darkgrue

Just received a PR from @steve-grb that should fix this in #170 I have merged to the RC branch and will release an rc version shortly for testing. You can change the plugin's release channel in OctoPrint's Software Update settings to Release Candidate and upgrade when prompted to get the changes and confirm everything is working as expected.

jneilliii avatar Jan 13 '22 21:01 jneilliii

Actually, I take that back. Steve's fix was not for the additional items showing, but the actual icon not being clickable in TouchUI.

jneilliii avatar Jan 13 '22 21:01 jneilliii

I do believe this is something I can fix with some css tricks, just have to experiment with it.

jneilliii avatar Jan 13 '22 21:01 jneilliii

@darkgrue the one that doesn't show anything is the Tasmota tab. It has a plotly.js graph on it with graphed sensor data. If it's completely blank then your device or browser probably doesn't support webgl. Can you provide more details as to what browser/device you are using?

jneilliii avatar Jan 14 '22 00:01 jneilliii

@darkgrue the one that doesn't show anything is the Tasmota tab. It has a plotly.js graph on it with graphed sensor data. If it's completely blank then your device or browser probably doesn't support webgl. Can you provide more details as to what browser/device you are using?

At the time, I was using Chrome on Windows 10.

darkgrue avatar Jan 17 '22 00:01 darkgrue